Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline: stop ignoring failures from pxe-install scenario #257

Merged
merged 1 commit into from
Jul 20, 2020
Merged

pipeline: stop ignoring failures from pxe-install scenario #257

merged 1 commit into from
Jul 20, 2020

Conversation

bgilbert
Copy link
Contributor

coreos/coreos-assembler#1597 is fixed. This reverts commit c175ec0.

dustymabe
dustymabe approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jlebon
jlebon approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yup, thanks!

@jlebon jlebon merged commit 3023f12 into coreos:master Jul 20, 2020
@bgilbert bgilbert deleted the unignore branch July 20, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgilbert @dustymabe @jlebon